Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Box64 with muvm #140

Closed
wants to merge 4 commits into from
Closed

Use Box64 with muvm #140

wants to merge 4 commits into from

Conversation

m1m1k4tz
Copy link
Contributor

No description provided.

Copy link
Member

@asahilina asahilina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does box64 actually benefit from muvm? I thought they were doing the fake page size emulation thing...

This should probably be a command line argument, I'm not sure if automatically falling back to box64 makes sense. That could cause confusion for users who don't understand that the config is based on what packages are installed.

crates/muvm/src/guest/box64.rs Outdated Show resolved Hide resolved
@teohhanhui
Copy link
Collaborator

@ptitSeb
Copy link
Contributor

ptitSeb commented Jan 19, 2025

Does box64 actually benefit from muvm?

Yes it does benifit from proper 4K pagesize

I thought they were doing the fake page size emulation thing...

There is a fake 4k page size simulation, but it's not a perfect emulation. Far from it. It allow some linux program to be load easily, but everything that rely on 4k pagesize will just not work (like wine or steam).

This should probably be a command line argument, I'm not sure if automatically falling back to box64 makes sense. That could cause confusion for users who don't understand that the config is based on what packages are installed.

While a command line argument is fine, I don't see why automatic fallback to box64 if present would be confusing.

@m1m1k4tz
Copy link
Contributor Author

Does box64 actually benefit from muvm? I thought they were doing the fake page size emulation thing...

Right now muvm is required for wine to work under box64

@m1m1k4tz m1m1k4tz requested a review from asahilina January 19, 2025 09:51
@alyssarosenzweig
Copy link
Member

I'm OK with this

@slp
Copy link
Collaborator

slp commented Jan 22, 2025

@m1m1k4tz @ptitSeb Do you mind if I pick up this one and improve it a bit in a new PR? I'd like to:

  • Add a flag for explicitly choosing the emulator.
  • Improve the commits title and summary.
  • Add SoB.

@ptitSeb
Copy link
Contributor

ptitSeb commented Jan 22, 2025

@m1m1k4tz @ptitSeb Do you mind if I pick up this one and improve it a bit in a new PR? I'd like to:

  • Add a flag for explicitly choosing the emulator.
  • Improve the commits title and summary.
  • Add SoB.

I don't mind. Adding flags for explicitly choose one of the emu is good thing to add!

slp added a commit to slp/krun that referenced this pull request Jan 31, 2025
Add the "emu" command line argument to let users choose the emulator to
be used for running x86 binaries. Add support for installing Box64 in
binfmt_misc. If the argument is not present in the command line, try to
use FEX first and if it can't be set up, try again with Box64.

Supersedes: AsahiLinux#140
Co-authored-by: ptitSeb <[email protected]>
Co-authored-by: Alex Arnold <[email protected]>
Signed-off-by: Sergio Lopez <[email protected]>
slp added a commit to slp/krun that referenced this pull request Jan 31, 2025
Add the "emu" command line argument to let users choose the emulator to
be used for running x86 binaries. Add support for installing Box64 in
binfmt_misc. If the argument is not present in the command line, try to
use FEX first and if it can't be set up, try again with Box64.

Supersedes: AsahiLinux#140
Co-authored-by: ptitSeb <[email protected]>
Co-authored-by: Alex Arnold <[email protected]>
Signed-off-by: Sergio Lopez <[email protected]>
@m1m1k4tz m1m1k4tz closed this Jan 31, 2025
slp added a commit to slp/krun that referenced this pull request Feb 3, 2025
Add the "emu" command line argument to let users choose the emulator to
be used for running x86 binaries. Add support for installing Box64 in
binfmt_misc. If the argument is not present in the command line, try to
use FEX first and if it can't be set up, try again with Box64.

Supersedes: AsahiLinux#140
Co-authored-by: ptitSeb <[email protected]>
Co-authored-by: Alex Arnold <[email protected]>
Signed-off-by: Sergio Lopez <[email protected]>
slp added a commit that referenced this pull request Feb 3, 2025
Add the "emu" command line argument to let users choose the emulator to
be used for running x86 binaries. Add support for installing Box64 in
binfmt_misc. If the argument is not present in the command line, try to
use FEX first and if it can't be set up, try again with Box64.

Supersedes: #140
Co-authored-by: ptitSeb <[email protected]>
Co-authored-by: Alex Arnold <[email protected]>
Signed-off-by: Sergio Lopez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants